Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #7619] Support autocorrect of legacy names for Migration/DepartmentName #7685

Conversation

koic
Copy link
Member

@koic koic commented Feb 4, 2020

Fixes #7619.

This PR supports autocorrect of legacy names for Migration/DepartmentName.

Auto-correction for legacy names complements legacy department names.
Migration to new cop names are expected to be modified using Gry gem.
https://github.com/pocke/gry


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

…/DepartmentName`

Fixes rubocop#7619.

This PR supports autocorrect of legacy cop names for
`Migration/DepartmentName`.

Auto-correction for legacy cop names complements legacy department names.
Migration to new cop names are expected to be modified using Gry gem.
https://github.com/pocke/gry
@koic koic force-pushed the support_autocorrect_of_legacy_names_for_department_name branch from a83dd69 to dd358d4 Compare February 4, 2020 16:19
@bbatsov bbatsov merged commit 28eb777 into rubocop:master Feb 4, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Feb 4, 2020

Thanks!

@tas50
Copy link
Contributor

tas50 commented Feb 4, 2020

Thanks @koic

@koic koic deleted the support_autocorrect_of_legacy_names_for_department_name branch February 4, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration/DepartmentName fails to autocorrect, but says it does
3 participants