[Fix #7675] Fix a false negative for Layout/SpaceBeforeFirstArg
#7678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure will be resolved by #7679. |
koic
force-pushed
the
fix_false_negative_for_layout_space_before_first_arg
branch
from
cd4c29a
to
63837bb
Compare
bbatsov
reviewed
Jan 31, 2020
|
|
||
| first_arg = node.first_argument | ||
|
|
||
| same_line?(first_arg, node) && | ||
| !(allow_for_alignment? && | ||
| aligned_with_something?(first_arg.source_range)) | ||
| end | ||
|
|
||
| def touch_between_method_name_and_first_argument?(node) |
There was a problem hiding this comment.
I'm not sure I understand the name of this method. What is touch between supposed to mean?
There was a problem hiding this comment.
Ah, I did a confusing naming 💦
I'd like to change the name to def no_space_between_method_name_and_first_argument?
# no space (bad)
do_something'arg'
# with space (good)
do_something 'arg' There was a problem hiding this comment.
Thank you for your review. I updated the method name.
Fixes rubocop#7675. This PR fixes a false negative for `Layout/SpaceBeforeFirstArg` when a vertical argument positions are aligned.
koic
force-pushed
the
fix_false_negative_for_layout_space_before_first_arg
branch
from
63837bb
to
03cc4f9
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7675.
This PR fixes a false negative for
Layout/SpaceBeforeFirstArgwhen a vertical argument positions are aligned.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.