New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix #7647] Handle numblock #7665
Conversation
Thanks for your pull request 👍 We still need to apply more changes to make cops to work for I think this pull request is acceptable without more support for |
CHANGELOG.md
Outdated
@@ -6,6 +6,7 @@ | |||
|
|||
* [#7639](https://github.com/rubocop-hq/rubocop/pull/7639): Fix logical operator edge case in `omit_parentheses` style of `Style/MethodCallWithArgsParentheses`. ([@gsamokovarov][]) | |||
* [#7661](https://github.com/rubocop-hq/rubocop/pull/7661): Fix to return correct info from multi-line regexp. ([@Tietew][]) | |||
* [#7647](https://github.com/rubocop-hq/rubocop/issues/7647): Handle numblock. ([@hanachin][]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @pocke mentions at #7665 (comment), this patch doesn't solve all known issue of numblock
. So the Handle numblock
seems a bit broad sense to me. What about alternatives like the following message focused on resolving the error?
-* [#7647](https://github.com/rubocop-hq/rubocop/issues/7647): Handle numblock. ([@hanachin][])
+* [#7647](https://github.com/rubocop-hq/rubocop/issues/7647): Fix an `undefined method on_numblock` error when using Ruby 2.7's numbered parameters. ([@hanachin][])
e652c25
to
bca75ce
Compare
when using Ruby 2.7's numbered parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks! |
Fix #7647
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and RuboCop for itself, and generates the documentation.