Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept pending cops in the development build #7664

Merged
merged 1 commit into from
Jan 25, 2020

Commits on Jan 23, 2020

  1. Accept pending cops in the development build

    Follow up of rubocop#7646 (comment).
    
    This PR accepts pending cops in the development build.
    
    Some tests fail with the following warnings when using the
    `Enabled: pending` status.
    
    ```console
    % bundle exec rake spec
    (snip)
    
    1) RuboCop::CLI --only when one cop is given accepts cop names from
    plugins
         Failure/Error: raise output
    
         RuntimeError:
           The following cops were added to RuboCop, but are not
    configured. Please set Enabled to either `true` or `false` in your
    `.rubocop.yml` file:
            - Style/ZeroLengthPredicate
           Inspecting 2 files
           ..
    
           2 files inspected, no offenses detected
         # ./spec/rubocop/cli/cli_options_spec.rb:213:in `block (4 levels)
    in <top (required)>'
         # ./spec/support/cli_spec_behavior.rb:26:in `block (2 levels) in
    <top (required)>'
         # ./lib/rubocop/rspec/shared_contexts.rb:29:in `block (4 levels) in
    <top (required)>'
         # ./lib/rubocop/path_util.rb:67:in `chdir'
         # ./lib/rubocop/path_util.rb:67:in `chdir'
         # ./lib/rubocop/rspec/shared_contexts.rb:28:in `block (3 levels) in
    <top (required)>'
         # ./lib/rubocop/rspec/shared_contexts.rb:8:in `block (2 levels) in
    <top (required)>'
    ```
    
    This PR prevents those tests from catching a pending cop warning.
    OTOH, this PR supplements the E2E test for a pending cop warning.
    koic committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    5d6e0a3 View commit details
    Browse the repository at this point in the history