Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #7590] Fix an error for Layout/SpaceBeforeBlockBraces #7591

Merged

Conversation

koic
Copy link
Member

@koic koic commented Dec 24, 2019

Fixes #7590.

This PR fixes an error for Layout/SpaceBeforeBlockBraces when using with EnforcedStyle: line_count_based of Style/BlockDelimiters cop.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Fixes rubocop#7590.

This PR fixes an error for `Layout/SpaceBeforeBlockBraces` when using with
`EnforcedStyle: line_count_based` of `Style/BlockDelimiters` cop.
@bbatsov bbatsov merged commit c66efb9 into rubocop:master Dec 25, 2019
@bbatsov
Copy link
Collaborator

bbatsov commented Dec 25, 2019

Thanks!

@koic koic deleted the fix_an_error_for_space_before_block_braces_spec branch December 25, 2019 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout/SpaceBeforeBlockBraces cop raises RuntimeError
2 participants