Bring ABC size down to 16 #7453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drenmi
commented
Oct 23, 2019
| @@ -429,6 +429,7 @@ def compile_ellipsis | |||
| [0..Float::INFINITY, 'true'] | |||
| end | |||
|
|
|||
| # rubocop:disable Metrics/AbcSize | |||
There was a problem hiding this comment.
Couldn't find any way to refactor this method that didn't make it worse. Pretty sure this is as good as it gets with the current design, but open to suggestions.
There was a problem hiding this comment.
Challenge accepted 😉 #7457
|
🙇 |
Drenmi
commented
Oct 24, 2019
| @condition += 1 | ||
| end | ||
|
|
||
| def else_branch?(node) | ||
| %i[case if].include?(node.type) && |
There was a problem hiding this comment.
@jonas054 I suspect we could have a subtle bug here. We check for #else_branch? on CONDITION_NODES, which comes from CyclomaticComplexity::COUNTED_NODES, but that list does not include case:
COUNTED_NODES = %i[if while until for
rescue when and or].freeze
so meta 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to cement the excellent work done by @buehmann in #7450 by bringing the bar down to 16. That way we can't have new offenses creeping in without notice.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.