Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #7446] Add merge to NONMUTATING_METHODS #7448

Merged
merged 1 commit into from Oct 21, 2019
Merged

[Fix #7446] Add merge to NONMUTATING_METHODS #7448

merged 1 commit into from Oct 21, 2019

Conversation

cstyles
Copy link
Contributor

@cstyles cstyles commented Oct 19, 2019

Fixes #7446

Now, if merge is used in a void context, the Lint/Void cop will
register an offense and the mutating merge! method will be suggested.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Fixes #7446

Now, if `merge` is used in a void context, the `Lint/Void` cop will
register an offense and the mutating `merge!` method will be suggested.
@bbatsov bbatsov merged commit e436938 into rubocop:master Oct 21, 2019
@bbatsov
Copy link
Collaborator

bbatsov commented Oct 21, 2019

Thanks!

@cstyles cstyles deleted the add-offense-for-void-merge branch October 22, 2019 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to detect when the result of Array#sort isn't captured?
2 participants