[Fix #7320] support Naming/MethodName for attr_reader / attr_writer / attr_accessor #7372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still don't see any tests covering the use of |
bbatsov
reviewed
Sep 20, 2019
|
|
||
| MSG = 'Use %<style>s for method names.' | ||
|
|
||
| def_node_matcher :attr?, <<~PATTERN |
There was a problem hiding this comment.
Btw, there's also define_method that should be considered. In general it might be a good idea be able to provide a list of method names that define methods via configuration so custom macros could be accounted as well.
|
@bbatsov added. But.... It works only when you pass symbols, but should it also support strings ? |
|
I guess it should handle strings as well. |
bbatsov
reviewed
Sep 23, 2019
| it 'registers an offense for camel case methods names in attr.' do | ||
| expect_offense(<<~RUBY) | ||
| attr :my_method, :myMethod | ||
| ^^^^^^^^^^^^^^^^^^^^^ Use #{enforced_style} for method names. |
There was a problem hiding this comment.
Shouldn't we highlight just the second symbol here?
There was a problem hiding this comment.
Will check it. Do you know maybe some cops that have similar behavior?
So it should be something like that ?
attr :my_method, :myMethod, my_snake_method, :myCamelMethod
^^^^^^^^^^ ^^^^^^^^^^^^^^ Use #{enforced_style} for method names.
cdmo
pushed a commit
to psu-libraries/myaccount
that referenced
this pull request
Nov 15, 2019
…wasn't caught by rubocop but will in the future with this rubocop/rubocop#7372
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7320
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.