Fix #7320 support Naming/MethodName for attr_reader / attr_writer / attr_accessor #7342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see unit tests for |
bbatsov
reviewed
Sep 15, 2019
| it 'registers an offense for mixed snake case and camel case in attr.' do | ||
| expect_offense(<<~RUBY) | ||
| attr_reader :visit_Arel_Nodes_SelectStatement | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use #{enforced_style} for method names. |
There was a problem hiding this comment.
I guess we should highlight just the symbol, not the entire expression.
|
Okay, rebase and force push goes wrong, tomorrow will re-open with fixed code :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7320
One thing: node matchers here from here https://github.com/rubocop-hq/rubocop/blob/master/lib/rubocop/cop/lint/duplicate_methods.rb#L98, I don't know if there are possibility to use them without duplication.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.