[Fix #7299] Implement Lint/RaiseException cop #7325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drenmi
approved these changes
Sep 3, 2019
|
Thanks @denys281! 🙏 |
bbatsov
reviewed
Sep 4, 2019
bbatsov
reviewed
Sep 4, 2019
| Lint/RaiseException: | ||
| Description: Checks for `raise` or `fail` statements which is raise `Exception` class. | ||
| Enabled: true | ||
| VersionAdded: '0.75' |
There was a problem hiding this comment.
Is this in the style guide? If so - let's add a link to the rule.
There was a problem hiding this comment.
@bbatsov no, we have only this one https://github.com/rubocop-hq/ruby-style-guide#no-blind-rescues
There was a problem hiding this comment.
Guess we can add something on the subject there then.
There was a problem hiding this comment.
@bbatsov Did you mean in style guide?
There was a problem hiding this comment.
bbatsov
reviewed
Sep 4, 2019
bbatsov
reviewed
Sep 4, 2019
denys281
force-pushed
the
7299
branch
2 times, most recently
from
092beae
to
8bd6403
Compare
|
Better late than never! :-) Thanks! |
olleolleolle
added a commit
to barsoom/barsoom_utils
that referenced
this pull request
Sep 14, 2020
- introduced in 0.81.0, rubocop/rubocop#7325
olleolleolle
added a commit
to barsoom/barsoom_utils
that referenced
this pull request
Sep 14, 2020
- introduced in 0.81.0, rubocop/rubocop#7325
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7299
Should go with rubocop/ruby-style-guide#775
Cop checks for:
raise Exception;raise Exception, 'error message';failand::ExceptionBefore submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.