Fix an infinite loop error for Layout/SpaceInsideBlockBraces

CHANGELOG.md

@@ -14,6 +14,7 @@
 * [#7099](https://github.com/rubocop-hq/rubocop/issues/7099): Fix an error of `Layout/RescueEnsureAlignment` on assigned blocks. ([@tatsuyafw][])
 * [#5088](https://github.com/rubocop-hq/rubocop/issues/5088): Fix an error of `Layout/MultilineMethodCallIndentation` on method chains inside an argument. ([@buehmann][])
 * [#4719](https://github.com/rubocop-hq/rubocop/issues/4719): Make `Layout/Tab` detect tabs between string literals. ([@buehmann][])
+* [#7203](https://github.com/rubocop-hq/rubocop/pull/7203): Fix an infinite loop error for `Layout/SpaceInsideBlockBraces` when `EnforcedStyle: no_space` with `SpaceBeforeBlockParameters: false` are set in multiline block. ([@koic][])
 
 ### Changes
 

lib/rubocop/cop/layout/space_inside_block_braces.rb

@@ -130,7 +130,8 @@ def braces_with_contents_inside(node, inner)
           args_delimiter = node.arguments.loc.begin # Can be ( | or nil.
 
           check_left_brace(inner, node.loc.begin, args_delimiter)
-          check_right_brace(inner, node.loc.end, node.single_line?)
+          check_right_brace(inner, node.loc.begin, node.loc.end,
+                            node.single_line?)
         end
 
         def check_left_brace(inner, left_brace, args_delimiter)
@@ -141,15 +142,26 @@ def check_left_brace(inner, left_brace, args_delimiter)
           end
         end
 
-        def check_right_brace(inner, right_brace, single_line)
+        def check_right_brace(inner, left_brace, right_brace, single_line)
           if single_line && inner =~ /\S$/
             no_space(right_brace.begin_pos, right_brace.end_pos,
                      'Space missing inside }.')
           else
+            return if multiline_block?(left_brace, right_brace) &&
+                      aligned_braces?(left_brace, right_brace)
+
             space_inside_right_brace(right_brace)
           end
         end
 
+        def multiline_block?(left_brace, right_brace)
+          left_brace.first_line != right_brace.first_line
+        end
+
+        def aligned_braces?(left_brace, right_brace)
+          left_brace.first_line == right_brace.last_column
+        end
+
         def no_space_inside_left_brace(left_brace, args_delimiter)
           if pipe?(args_delimiter)
             if left_brace.end_pos == args_delimiter.begin_pos &&

spec/rubocop/cop/layout/space_inside_block_braces_spec.rb

@@ -329,6 +329,27 @@
           expect_no_offenses('->(x) {x}')
         end
 
+        it 'does not register an offense when braces are aligned in ' \
+           'multiline block' do
+          expect_no_offenses(<<~RUBY)
+            items.map {|item|
+              item.do_something
+            }
+          RUBY
+        end
+
+        it 'registers an offense when braces are not aligned in ' \
+           'multiline block' do
+          inspect_source(<<~RUBY)
+            items.map {|item|
+              item.do_something
+              }
+          RUBY
+
+          expect(cop.offenses.size).to eq(1)
+          expect(cop.messages).to eq(['Space inside } detected.'])
+        end
+
         it 'auto-corrects unwanted space' do
           new_source = autocorrect_source('each { |x| puts}')
           expect(new_source).to eq('each {|x| puts}')