Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect DisabledByDefault for custom cops #7013

Merged
merged 2 commits into from
May 15, 2019
Merged

Respect DisabledByDefault for custom cops #7013

merged 2 commits into from
May 15, 2019

Commits on May 14, 2019

  1. Respect DisabledByDefault for custom cops 

    Before this commit, DisabledByDefault has no effect on
custom cops and they are enabled when the config files
contain no mention of them. This is a problematic
behavior as CI servers might load multiple custom cop
and run Rubocop over repos with vastly different
configs. Custom cops end up enabled for repos that
don't care about them, simply because they are loaded.
    @XrXr
    XrXr committed May 14, 2019
    Configuration menu
    Copy the full SHA
    7b145eb View commit details
    Browse the repository at this point in the history

Commits on May 15, 2019

  1. Merge branch 'master' into custom-cop-disabled-by-default

    @bbatsov
    bbatsov committed May 15, 2019
    Configuration menu
    Copy the full SHA
    2f6b7dd View commit details
    Browse the repository at this point in the history