Mark Naming/RescuedExceptionsVariableName as unsafe #6994
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just ran
rubocop --safe-auto-correct
and it made this autocorrect change:This is obviously a breaking change. I believe the easiest fix here is to mark this cop as unsafe, as, as far as I know, rubocop doesn't offer the extensive functionality for renaming a variable (
redirection
) across all of its usages.I'm open for suggestions for better fix.
EDIT: I dug down and realized this has just recently been added by @anthony-robin (Thanks!) in this PR #6905. @anthony-robin, what do you think of marking this cop unsafe?
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default
. It executes all tests and RuboCop for itself, and generates the documentation.