Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #6974] Make Layout/FirstMethodArgumentLineBreak aware of calling using super #6976

Merged

Conversation

koic
Copy link
Member

@koic koic commented Apr 26, 2019

Fixes #6974.

This PR makes Layout/FirstMethodArgumentLineBreak aware of calling using super.

# example.rb
super(:foo,
  :bar
  )

Before

% rubocop --only Layout/FirstMethodArgumentLineBreak
Inspecting 1 file
.

1 file inspected, no offenses detected

After

% rubocop --only Layout/FirstMethodArgumentLineBreak
Inspecting 1 file
C

Offenses:

example.rb:1:7: C: Layout/FirstMethodArgumentLineBreak: Add a line break
before the first argument of a multi-line method argument list.
super(:foo,
      ^^^^

1 file inspected, 1 offense detected

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

…f calling using `super`

Fixes rubocop#6974.

This PR makes `Layout/FirstMethodArgumentLineBreak` aware of calling using `super`.

```ruby
# example.rb
super(:foo,
  :bar
  )
```

## Before

```console
% rubocop --only Layout/FirstMethodArgumentLineBreak
Inspecting 1 file
.

1 file inspected, no offenses detected
```

## After

```console
% rubocop --only Layout/FirstMethodArgumentLineBreak
Inspecting 1 file
C

Offenses:

example.rb:1:7: C: Layout/FirstMethodArgumentLineBreak: Add a line break
before the first argument of a multi-line method argument list.
super(:foo,
      ^^^^

1 file inspected, 1 offense detected
```
Copy link
Collaborator

@Drenmi Drenmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@koic koic merged commit 1457ce8 into rubocop:master Apr 27, 2019
@koic koic deleted the first_method_argument_line_break_aware_of_super branch April 27, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FirstMethodArgumentLineBreak cop doesn't work for super
2 participants