Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #6956] Prevent auto-correct confliction of Lint/Lambda and Lint/UnusedBlockArgument #6958

Conversation

koic
Copy link
Member

@koic koic commented Apr 23, 2019

Fixes #6956.

This PR prevents auto-correct confliction of Lint/Lambda and Lint/UnusedBlockArgument.

The following is the reproduction procedure.

# example.rb
c = -> event do
  puts 'Hello world'
end
% rubocop example.rb -a --only Style/Lambda,Lint/UnusedBlockArgument

Before

A reserved word lambda is broken.

% git diff
diff --git a/example.rb b/example.rb
index 3445c6f..b8e24f4 100644
--- a/example.rb
+++ b/example.rb
@@ -1,3 +1,3 @@
-c = -> event do
+c = lambda_ do |_event|
   puts 'Hello world'
 end

After

It will be a valid code.

% git diff
diff --git a/example.rb b/example.rb
index 3445c6f..9c22b37 100644
--- a/example.rb
+++ b/example.rb
@@ -1,3 +1,3 @@
-c = -> event do
+c = lambda do |_event|
   puts 'Hello world'
 end

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

…and `Lint/UnusedBlockArgument`

Fixes rubocop#6956.

This PR prevents auto-correct confliction of `Lint/Lambda` and `Lint/UnusedBlockArgument`.

The following is the reproduction procedure.

```ruby
# example.rb
c = -> event do
  puts 'Hello world'
end
```

```console
% rubocop example.rb -a --only Style/Lambda,Lint/UnusedBlockArgument
```

## Before

A reserved word `lambda` is broken.

```diff
% git diff
diff --git a/example.rb b/example.rb
index 3445c6f..b8e24f4 100644
--- a/example.rb
+++ b/example.rb
@@ -1,3 +1,3 @@
-c = -> event do
+c = lambda_ do |_event|
   puts 'Hello world'
 end
```

## After

It will be a valid code.

```diff
% git diff
diff --git a/example.rb b/example.rb
index 3445c6f..9c22b37 100644
--- a/example.rb
+++ b/example.rb
@@ -1,3 +1,3 @@
-c = -> event do
+c = lambda do |_event|
   puts 'Hello world'
 end
```
end
end

def correct_for_blockarg_type(node)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 I extracted to the method because it was warned by Metrics cops.

@bbatsov bbatsov merged commit 9a40076 into rubocop:master Apr 23, 2019
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 23, 2019

Thanks!

@koic koic deleted the prevent_autocorrect_for_lambda_and_unused_block_arg branch April 23, 2019 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style/Lambda with unused argument bug
2 participants