[Fix #6860] Prevent auto-correct confliction of Style::InverseMethods and Style::Not #6951
+20
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drenmi
reviewed
Apr 22, 2019
CHANGELOG.md
Outdated
| @@ -18,6 +18,7 @@ | |||
| * [#6946](https://github.com/rubocop-hq/rubocop/pull/6946): Allow `Rails/ReflectionClassName` to use string interpolation for `class_name`. ([@r7kamura][]) | |||
| * [#6778](https://github.com/rubocop-hq/rubocop/issues/6778): Fix a false positive in `Style/HashSyntax` cop when a hash key is an interpolated string and EnforcedStyle is ruby19_no_mixed_keys. ([@tatsuyafw][]) | |||
| * [#6902](https://github.com/rubocop-hq/rubocop/issues/6902): Fix a bug where `Naming/RescuedExceptionsVariableName` would handle an only first rescue for multiple rescue groups. ([@tatsuyafw][]) | |||
| * [#6860](https://github.com/rubocop-hq/rubocop/issues/6860): Prevent auto-correct confliction of Style::InverseMethods and Style::Not. ([@hoshinotsuyoshi][]) | |||
There was a problem hiding this comment.
Minor nits:
"confliction" -> "conflict"
"Style::InverseMethods" -> "Style/InverseMethods"
"Style::Not" -> "Style/Not"
🙇
hoshinotsuyoshi
force-pushed
the
autocorrect_confliction_inverse_methods
branch
from
e785199
to
0656f7d
Compare
koic
reviewed
Apr 22, 2019
CHANGELOG.md
Outdated
| @@ -18,6 +18,7 @@ | |||
| * [#6946](https://github.com/rubocop-hq/rubocop/pull/6946): Allow `Rails/ReflectionClassName` to use string interpolation for `class_name`. ([@r7kamura][]) | |||
| * [#6778](https://github.com/rubocop-hq/rubocop/issues/6778): Fix a false positive in `Style/HashSyntax` cop when a hash key is an interpolated string and EnforcedStyle is ruby19_no_mixed_keys. ([@tatsuyafw][]) | |||
| * [#6902](https://github.com/rubocop-hq/rubocop/issues/6902): Fix a bug where `Naming/RescuedExceptionsVariableName` would handle an only first rescue for multiple rescue groups. ([@tatsuyafw][]) | |||
| * [#6860](https://github.com/rubocop-hq/rubocop/issues/6860): Prevent auto-correct conflict of Style/InverseMethods and Style/Not. ([@hoshinotsuyoshi][]) | |||
There was a problem hiding this comment.
Cop names are preferably quoted :-)
-Prevent auto-correct conflict of Style/InverseMethods and Style/Not. ([@hoshinotsuyoshi][])
+Prevent auto-correct conflict of `Style/InverseMethods` and `Style/Not`. ([@hoshinotsuyoshi][])…hods` and `Style/Not`.
Prevent conflict problem like below:
file:
```
x.select { |y| not y.z }
```
auto-correct:
```
$ bundle exec rubocop -a c.rb --only Style/InverseMethods,Style/Not
Inspecting 1 file
C
Offenses:
c.rb:1:1: C: [Corrected] Style/InverseMethods: Use reject instead of inverting select.
x.select { |y| not y.z }
^^^^^^^^^^^^^^^^^^^^^^^^
c.rb:1:1: C: [Corrected] Style/InverseMethods: Use select instead of inverting reject.
x.reject { |y| !y.z }
^^^^^^^^^^^^^^^^^^^^^
c.rb:1:16: C: [Corrected] Style/Not: Use ! instead of not.
x.select { |y| not y.z }
^^^
1 file inspected, 3 offenses detected, 3 offenses corrected
```
corrected badly:
```
x.select { |y| y.z }
```
hoshinotsuyoshi
force-pushed
the
autocorrect_confliction_inverse_methods
branch
from
0656f7d
to
4e2b19d
Compare
|
Thanks! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6860.
Prevent confliction problem like below:
file:
auto-correct:
corrected badly:
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.