Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #6902] Naming/RescuedExceptionsVariableName for multiple rescues #6949

Conversation

tatsuyafw
Copy link
Contributor

Fixes #6902 .

As issued in #6902, the Naming/RescuedExceptionsVariableName cop did not handle multiple rescues as below.

begin
  # something
rescue FooException => foo # <= flagged
rescue BarException => bar # <= not flagged
end

This PR fixes that and enable the cop handle multiple rescues.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

…e rescues

As issued in rubocop#6902, the `Naming/RescuedExceptionsVariableName` cop did not
handle multiple rescues as below.

```
begin
  # something
rescue FooException => foo # <= flagged
rescue BarException => bar # <= not flagged
end
```

This changes fix that and enable the cop handle multiple rescues.
@bbatsov bbatsov merged commit b0b9d39 into rubocop:master Apr 20, 2019
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 20, 2019

Thanks!

@tatsuyafw tatsuyafw deleted the bugfix/naming-rescued-exceptions-variable-name branch April 20, 2019 09:33
@tatsuyafw
Copy link
Contributor Author

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Naming/RescuedExceptionsVariableName does not handle multiple rescues
2 participants