Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #6939] Remove warn for rubocop-performance #6944

Merged
merged 1 commit into from Apr 17, 2019

Conversation

koic
Copy link
Member

@koic koic commented Apr 17, 2019

Fixes #6939.
Fixes #6917.

This warning should not be displayed if users don't use Performance cops as follows:

In the future, it will be better to replace it with a mechanism that displays a warning only when the user need Performance cops.

This PR removes a warning for rubocop-performance when runinng rubocop command.

It just leave a warning just to gem install rubocop.
https://github.com/rubocop-hq/rubocop/blob/v0.67.2/rubocop.gemspec#L47


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Fixes rubocop#6939.
Fixes rubocop#6917.

This warning should not be displayed if users don't use Performance cops
as follows:

- rubocop#6845 (comment)
- rubocop#6919 (comment)

In the future, it will be better to replace it with a mechanism that
displays a warning only when the user need Performance cops.

This PR removes a warning for rubocop-performance when runinng `rubocop`
command.

It just leave a warning just to `gem install rubocop`.
https://github.com/rubocop-hq/rubocop/blob/v0.67.2/rubocop.gemspec#L47
@bbatsov bbatsov merged commit b6b9ae1 into rubocop:master Apr 17, 2019
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 17, 2019

Thanks!

@koic koic deleted the remove_warn_for_rubocop_performance branch April 17, 2019 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem in Gemfile-less folder Error while parsing Gemfile
2 participants