Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the warning about rubocop-performance from non-related output formats #6910

Conversation

AlexWayfer
Copy link
Contributor

@AlexWayfer AlexWayfer commented Apr 9, 2019

Fix AtomLinter/linter-rubocop#309 after #6845


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@AlexWayfer AlexWayfer changed the title Remove the warning about rubocop-performance from non-related outpu… Remove the warning about rubocop-performance from non-related output formats Apr 9, 2019
@AlexWayfer AlexWayfer force-pushed the remove_warn_from_non-text_formats branch 2 times, most recently from 8b6cb24 to 772715d Compare April 10, 2019 12:25
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 10, 2019

I don't quite get the fix. Why move this to one particular output format? That'd be almost the same as removing it completely.

@AlexWayfer AlexWayfer force-pushed the remove_warn_from_non-text_formats branch from 772715d to 037b61f Compare April 10, 2019 15:50
@AlexWayfer
Copy link
Contributor Author

AlexWayfer commented Apr 10, 2019

I don't quite get the fix.

Did you read the commit message (PR description)? There is the issue with tools which rely on RuboCop JSON (or another standard) output. The current output in JSON format (--format=json) is invalid JSON. I think, the same for HTML or other (quiet?) formats. Is this not enough? Have tools to bypass any non-formatted text somehow?


New conflicts resolved.

@bbatsov
Copy link
Collaborator

bbatsov commented Apr 10, 2019

Why are those tools reading something from stderr? That seems pretty weird.

@AlexWayfer
Copy link
Contributor Author

Why are those tools reading something from stderr? That seems pretty weird.

Let me try to discuss this in the tool's issue. Thank you for advice.

@AlexWayfer
Copy link
Contributor Author

I think, we can solve it in tools. Thank you, sorry to bother you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants