[Fix #5977] Remove Performance cops #6890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rubocop#5977. This PR removes Performance cops from RuboCop core. These cops were transferred to rubocop-hq/rubocop-performance repository. https://github.com/rubocop-hq/rubocop-performance
|
It may be better to merge this PR when we decide the next release version is RuboCop 0.68. |
|
I agree. I'll wait for a couple of days to see if we'll need another bugfix release for 0.67 and aim to merge this on Monday. |
|
There are a few small problems with |
|
P.S. Once again - fantastic work, @koic! |
|
I get it! Thanks too, @bbatsov! |
koic
added a commit
to koic/rubocop
that referenced
this pull request
May 7, 2019
Follow up rubocop#6890. `spec/rubocop/cop/performance/caller_spec.rb` has been moved from rubocop-hq/rubocop repo to rubocop-hqrubocop-performance repo.
8 tasks
bbatsov
pushed a commit
that referenced
this pull request
May 7, 2019
Follow up #6890. `spec/rubocop/cop/performance/caller_spec.rb` has been moved from rubocop-hq/rubocop repo to rubocop-hqrubocop-performance repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5977.
This PR removes Performance cops from RuboCop core.
These cops were transferred to rubocop-hq/rubocop-performance repository.
https://github.com/rubocop-hq/rubocop-performance
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.