Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #6675] Avoid printing deprecation warnings about constants #6831

Merged

Conversation

elmasantos
Copy link
Contributor

@elmasantos elmasantos commented Mar 13, 2019

This PR prevents deprecation warnings about constants to be shown (issue #6675).

It was needed to implement a method called silence_warnings, since Kernel::silence_warnings was hiding RuboCop's warnings.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@bbatsov
Copy link
Collaborator

bbatsov commented Mar 14, 2019

Thanks for tackling this! The changes look good to me. Just add an entry in the changelog regarding them.

@elmasantos elmasantos force-pushed the prevent-cop-from-causing-warnings branch from e0ace0c to 87163ca Compare March 14, 2019 12:57
@elmasantos elmasantos force-pushed the prevent-cop-from-causing-warnings branch from 87163ca to 3a4d42a Compare March 14, 2019 13:08
@elmasantos
Copy link
Contributor Author

Thanks for the reply @bbatsov! I added an entry in the changelog. Could you check again? :D

@bbatsov bbatsov merged commit 76a1413 into rubocop:master Mar 14, 2019
@bbatsov
Copy link
Collaborator

bbatsov commented Mar 14, 2019

Thanks!

@elmasantos elmasantos deleted the prevent-cop-from-causing-warnings branch March 14, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants