Make Style/RedundantFreeze aware of methods that will produce frozen objects
#6784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrosenblum
force-pushed
the
redundant_freeze_immutable_methods
branch
from
8488665
to
35514db
Compare
mikegee
reviewed
Feb 20, 2019
rrosenblum
force-pushed
the
redundant_freeze_immutable_methods
branch
3 times, most recently
from
a8d4461
to
01fea6b
Compare
rrosenblum
force-pushed
the
redundant_freeze_immutable_methods
branch
2 times, most recently
from
47fe73e
to
d4d5835
Compare
bbatsov
reviewed
Mar 10, 2019
bbatsov
reviewed
Mar 10, 2019
bbatsov
reviewed
Mar 10, 2019
rrosenblum
force-pushed
the
redundant_freeze_immutable_methods
branch
2 times, most recently
from
4c1efb1
to
639e255
Compare
rrosenblum
force-pushed
the
redundant_freeze_immutable_methods
branch
from
639e255
to
a15269b
Compare
This was referenced Apr 29, 2019
casperisfine
pushed a commit
to casperisfine/rubocop
that referenced
this pull request
Sep 22, 2021
Ref: rubocop#6784 `ENV["foo"]` returns a mutable string. ```ruby >> ENV["PATH"].frozen? => true >> ENV["PATH"].object_id => 260 >> ENV["PATH"].object_id => 280 ``` As such it's perfectly legitimate to freeze them in a pattern such as: ```ruby PATH = ENV["PATH"].freeze ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was extract out of the PR to add strict mode to
Style/MutableConstants, #6126. This isn't an exhaustive list of methods that return immutable values, but it is at least a start.