Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add specs for Layout/RescueEnsureAlignment fix c8ab8d9 from #6254 #6771

Closed
wants to merge 1 commit into from

Conversation

oehlschl
Copy link

@oehlschl oehlschl commented Feb 16, 2019

This PR demonstrates that there are still unexpected issues with Layout/RescueEnsureAlignment even after issue #6254 was resolved. I'm not familiar enough with Rubocop internals to resolve the issue, but the specs still failing include the original test case from @ashmaroli.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@oehlschl oehlschl changed the title WIP: add specs for Layout/RescueEnsureAlignment fix c8ab8d9 add specs for Layout/RescueEnsureAlignment fix c8ab8d9 from #6254 Feb 16, 2019
Copy link
Collaborator

@Drenmi Drenmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test case! This one is open for grabs for anyone who wants to have a stab at it. 🙂

@formigarafa
Copy link

@Drenmi,

I created a pull request on top of this PR. But I got a bit confused about which base I should pick.
Should I have created the PR to this repo?

@Drenmi
Copy link
Collaborator

Drenmi commented Mar 6, 2019

@formigarafa I think it's easiest to fork RuboCop and start from current master, manually copying over the test cases from here. 🙂

@formigarafa
Copy link

Thank you, @Drenmi.

@stale
Copy link

stale bot commented May 8, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding!

@stale stale bot added the stale Issues that haven't been active in a while label May 8, 2019
@stale
Copy link

stale bot commented Jun 7, 2019

This issues been automatically closed due to lack of activity. Feel free to re-open it if you ever come back to it.

@stale stale bot closed this Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues that haven't been active in a while
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants