[Fix #6755] Prevent Style/TrailingCommaInArgument from breaking when a safe method call is chained on the offending method

[Drenmi]

This cop would error out on code like:

foo.bar(
  baz: 1,
)&.fetch(:qux)

This was happening because the cop wasn't taking csend (safe navigation) node types into consideration.

---

Before submitting the PR make sure the following are checked:

• Wrote good commit messages.
• Commit message starts with [Fix #issue-number] (if the related issue exists).
• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
• The PR relates to only one subject with a clear title
  and description in grammatically correct, complete sentences.
• Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

[hoshinotsuyoshi]

@Drenmi
🙇 Sorry, It seems that PR #6749 caused the error. And thank you for your quick responding!

🙇 I found another point in #method_name_and_arguments_on_same_line? and test case to fix...

patch: hoshinotsuyoshi@f25ee5b

diff --git a/lib/rubocop/cop/mixin/trailing_comma.rb b/lib/rubocop/cop/mixin/trailing_comma.rb
index f9754b07c..d2d91e1a8 100644
--- a/lib/rubocop/cop/mixin/trailing_comma.rb
+++ b/lib/rubocop/cop/mixin/trailing_comma.rb
@@ -91,7 +91,7 @@ module RuboCop
       end

       def method_name_and_arguments_on_same_line?(node)
-        node.send_type? &&
+        %i[csend send].include?(node.type) &&
           node.loc.selector.line == node.arguments.last.last_line &&
           node.last_line == node.arguments.last.last_line
       end
diff --git a/spec/rubocop/cop/style/trailing_comma_in_arguments_spec.rb b/spec/rubocop/cop/style/trailing_comma_in_arguments_spec.rb
index 77e0b3077..8ef6627ba 100644
--- a/spec/rubocop/cop/style/trailing_comma_in_arguments_spec.rb
+++ b/spec/rubocop/cop/style/trailing_comma_in_arguments_spec.rb
@@ -39,6 +39,14 @@ RSpec.describe RuboCop::Cop::Style::TrailingCommaInArguments, :config do
       RUBY
     end

+    it 'accepts method call without trailing comma ' \
+       'when a line break before a method call', :ruby23 do
+      expect_no_offenses(<<-RUBY.strip_indent)
+        obj
+          &.do_something(:foo, :bar)
+      RUBY
+    end
+
     it 'accepts method call without trailing comma with single element hash' \
         ' parameters at the end' do
       expect_no_offenses('some_method(a: 1)')

If you think it is ok, use this patch or add some code like that.

[Drenmi]

Thanks for following up @hoshinotsuyoshi! I have integrated your patch in the bugfix. 🙇

[koic]

Looks good to me. Could you please resolve the conflict?