Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #6737] Fix an incorrect auto-correct for Rails/LinkToBlank #6743

Merged
merged 1 commit into from Feb 7, 2019
Merged

[Fix #6737] Fix an incorrect auto-correct for Rails/LinkToBlank #6743

merged 1 commit into from Feb 7, 2019

Conversation

koic
Copy link
Member

@koic koic commented Feb 7, 2019

Fixes #6737.

This PR fixes an incorrect auto-correct for Rails/LinkToBlank when link_to method arguments are enclosed in parentheses.

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic koic mentioned this pull request Feb 7, 2019
Closed
@koic koic force-pushed the fix_incorrect_autocorrect_for_rails_link_to_blank branch from da8d1f0 to bad037a Compare February 7, 2019 07:24
pocke
pocke approved these changes Feb 7, 2019
View reviewed changes
Copy link
Collaborator

@pocke pocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote a comment, but looks good to me.
feel free to merge it!

lib/rubocop/cop/rails/link_to_blank.rb Outdated Show resolved Hide resolved
@koic
[Fix rubocop#6737] Fix an incorrect auto-correct for Rails/LinkToBlank
810c92f 
Fixes rubocop#6737.

This PR fixes an incorrect auto-correct for `Rails/LinkToBlank` when
`link_to` method arguments are enclosed in parentheses.
@koic koic force-pushed the fix_incorrect_autocorrect_for_rails_link_to_blank branch from bad037a to 810c92f Compare February 7, 2019 14:47
@koic koic merged commit 24e2c79 into rubocop:master Feb 7, 2019
@koic koic deleted the fix_incorrect_autocorrect_for_rails_link_to_blank branch February 7, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pocke pocke pocke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autocorrect for Rails/LinkToBlank is wrong for link_to with parentheses
3 participants
@koic @Intrepidd @pocke