Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect OS more consistently #6736

Merged
merged 1 commit into from Feb 6, 2019
Merged

Detect OS more consistently #6736

merged 1 commit into from Feb 6, 2019

Conversation

enkessler
Copy link
Contributor

This should fix #6720 and implements the suggested solution.

I did not add new tests, as testing this issue would require adding additional matrix combinations to the AppVeyor build (there is no JRuby/Windows combo being tested in CI) and I have no desire at this time to debug any failures on an entirely new build combination. I did run the default rake task locally and the results are no worse after than before the changes in this PR.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Using a different constant to determine the current operating system.
Copy link
Collaborator

@Drenmi Drenmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙇‍♂️

@koic koic merged commit 91dd462 into rubocop:master Feb 6, 2019
@koic
Copy link
Member

koic commented Feb 6, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout/EndOfLine does not choose correct default line ending
3 participants