Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #6725][Fix #6540] Mark Style/SymbolProc as unsafe for auto-correct #6730

Merged
merged 1 commit into from Feb 5, 2019

Conversation

Drenmi
Copy link
Collaborator

@Drenmi Drenmi commented Feb 5, 2019

Marking Style/SymbolProc as unsafe for auto-correct, since there are many cases where this is unsafe.

Some examples: #6725, #6540, #6448, #6052, #5098, #5009, #3071, #2135, #2588


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic koic merged commit c729869 into rubocop:master Feb 5, 2019
@koic
Copy link
Member

koic commented Feb 5, 2019

Thanks for showing the example issues!

@Malabarba
Copy link

Today I just randomly found out an issue I had forgotten about has been fixed less than a month ago. Thanks for all the work and effort you all put into rubocop!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants