[Fix #6722] Fix an error for Style/OneLineConditional
#6727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rubocop#6722. This PR fixes an error for `Style/OneLineConditional` when `then` branch has no body. The following is an error case. ```ruby # example.rb if cond then else dont end ``` The following is a reproduction step. ```console % rubocop -v 0.63.1 % rubocop -a example.rb --only Style/OneLineConditional Inspecting 1 file 0 files inspected, no offenses detected undefined method `type' for nil:NilClass /Users/koic/.rbenv/versions/2.6.1/lib/ruby/gems/2.6.0/gems/rubocop-0.63.1/lib/rubocop/cop/style/one_line_conditional.rb:74:in `requires_parentheses?' /Users/koic/.rbenv/versions/2.6.1/lib/ruby/gems/2.6.0/gems/rubocop-0.63.1/lib/rubocop/cop/style/one_line_conditional.rb:70:in `expr_replacement' /Users/koic/.rbenv/versions/2.6.1/lib/ruby/gems/2.6.0/gems/rubocop-0.63.1/lib/rubocop/cop/style/one_line_conditional.rb:65:in `to_ternary' (snip) ``` This PR auto-corrected to the following code. ```ruby cond ? nil : dont ``` Actually the above code is the same behavior as `unless` modifier. But this PR aims auto-corrected to an equivalent code without causing an error.
Closed
Yep. Sounds like another cop should be picking this up. 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6722.
This PR fixes an error for
Style/OneLineConditionalwhenthenbranch has no body. The following is an error case.The following is a reproduction step.
This PR auto-corrected to the following code.
Actually the above code is the same behavior as
unlessmodifier. But this PR aims auto-corrected to an equivalent code without causing an error.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.