Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid config in default.yml #6717

Closed
wants to merge 2 commits into from
Closed

Remove invalid config in default.yml #6717

wants to merge 2 commits into from

Conversation

tiev
Copy link

@tiev tiev commented Jan 30, 2019

I got this warning for the current config file.

Warning: Style/MethodCallWithArgsParentheses does not support AllowParenthesesInCamelCaseMethod parameter.

Supported parameters are:

  - Enabled
  - IgnoreMacros
  - IgnoredMethods
  - AllowParenthesesInMultilineCall
  - AllowParenthesesInChaining
  - EnforcedStyle
  - SupportedStyles

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

I got this warning for current config file.

```
Warning: Style/MethodCallWithArgsParentheses does not support AllowParenthesesInCamelCaseMethod parameter.

Supported parameters are:

  - Enabled
  - IgnoreMacros
  - IgnoredMethods
  - AllowParenthesesInMultilineCall
  - AllowParenthesesInChaining
  - EnforcedStyle
  - SupportedStyles
```
@pocke
Copy link
Collaborator

pocke commented Jan 30, 2019

Can you show me a .rubocop.yml to reproduce the warning? I cannot reproduce it.
AllowParenthesesInCamelCaseMethod option has not been released yet, so can you also show the commit hash of rubocop to reproduce?

This option has been introduced in #6643, and the configuration has been updated in #6697.

@tiev
Copy link
Author

tiev commented Jan 30, 2019

Can you show me a .rubocop.yml to reproduce the warning? I cannot reproduce it.
AllowParenthesesInCamelCaseMethod option has not been released yet, so can you also show the commit hash of rubocop to reproduce?

This option has been introduced in #6643, and the configuration has been updated in #6697.

Seems this is my fault. I inherit the default config from this repo, then accidentally introduce un-released config.
I close this now.

@tiev tiev closed this Jan 30, 2019
@tiev tiev deleted the patch-1 branch January 30, 2019 05:39
@pocke
Copy link
Collaborator

pocke commented Jan 30, 2019

I see. Thank you for your report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants