Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #6710] Fix Naming/MemoizedInstanceVariableName on method starts with underscore #6711

Merged
merged 1 commit into from Jan 26, 2019

Conversation

pocke
Copy link
Collaborator

@pocke pocke commented Jan 26, 2019

Fix #6710

Note: This pull request does not add test cases because the test case has been added in #6125. This pull request just removes pending.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Copy link
Member

@koic koic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable_name_candidates method is cool!

@koic koic merged commit a41aeb6 into rubocop:master Jan 26, 2019
@pocke pocke deleted the fix-6710 branch January 27, 2019 03:07
@Drenmi
Copy link
Collaborator

Drenmi commented Jan 28, 2019

🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants