Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #6701] Trailing comma detection regression with HEREDOC #6702

Merged
merged 1 commit into from Feb 7, 2019
Merged

[Fix #6701] Trailing comma detection regression with HEREDOC #6702

merged 1 commit into from Feb 7, 2019

Commits on Feb 7, 2019

  1. [Fix rubocop#6701] Trailing comma detection regression with HEREDOC 

    The TrailingCommaInArguments and TrailingCommaInArrayLiteral cops
have a false positive when the parent node contains HEREDOC with
commas in them. The issue appears to be due to lax comma detection.

Instead of only matching the last item for heredoc, match all items
and search for trailing commas, excluding newlines in match when
heredoc is present
    @abrom
    abrom committed Feb 7, 2019
    Copy the full SHA
    cec5f31 View commit details
    Browse the repository at this point in the history