[Fix: #6668] Fix autocorrect for UnneededCondition with unless #6693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
approved these changes
Jan 22, 2019
Drenmi
reviewed
Jan 23, 2019
| @@ -96,8 +96,9 @@ def else_source(else_branch) | |||
| end | |||
|
|
|||
| def make_ternary_form(node) | |||
| ternary_form = [node.if_branch.source, | |||
| else_source(node.else_branch)].join(' || ') | |||
| _condition, if_branch, else_branch = *node | |||
There was a problem hiding this comment.
Looking at this change makes me think something is awry with the node extension for IfNode ... 🤔
|
Sorry @mvz, there's a merge conflict in |
mvz
force-pushed
the
issue-6668-fix-unneeded-condition-autocorrect-with-unless
branch
from
5160888
to
c85e485
Compare
|
@Drenmi done, thanks! |
mvz
deleted the
issue-6668-fix-unneeded-condition-autocorrect-with-unless
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autocorrection of Style/UnneededCondition was broken for the
unlesscase. This change adds tests for it and ensures the condition is put first in the resulting expression. See #6668 for more details.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.