Move FlipFlop cop from Style to Lint department
#6636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up of rubocop#6635 (comment). flip-flop operator is deprecated since Ruby 2.6.0. > The flip-flop syntax is deprecated. [Feature rubocop#5400] - https://github.com/ruby/ruby/blob/v2_6_0/NEWS#language-changes - https://bugs.ruby-lang.org/issues/5400 This PR moves `FlipFlop` cop from `Style` department to `Lint` department.
koic
commented
Jan 8, 2019
| Description: 'Checks for flip-flops' | ||
| StyleGuide: '#no-flip-flops' | ||
| Enabled: true | ||
| VersionAdded: '0.16' |
There was a problem hiding this comment.
@bbatsov Is it necessary to add VersionChanged metadata when moving a department? I have not added VersionChanged: '0.63' because there is no behavior change of this cop.
danielmorrison
added a commit
to danielmorrison/standard
that referenced
this pull request
Jan 22, 2019
Rubocop 0.63.0 moved Style/FlipFlop to Lint/FlipFlop (rubocop/rubocop#6636) which generates a warning “…config/base.yml: Style/FlipFlop has the wrong namespace - should be Lint” when standard is run. This updates the base config and locks rubocop to >= 0.63.
y-yagi
added a commit
to y-yagi/rubocop-github
that referenced
this pull request
Jan 27, 2019
Rubocop 0.63.0 moved Style/FlipFlop to Lint/FlipFlop. Ref: rubocop/rubocop#6636 This updates the config and locks rubocop to ~> 0.63.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #6635 (comment).
flip-flop operator is deprecated since Ruby 2.6.0.
This PR moves
FlipFlopcop fromStyledepartment toLintdepartment.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.