Make Layout/AccessModifierIndentation work with arbitrary blocks #6574
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
Layout/AccessModifierIndentation
cop work for arbitrary blocks, and not only for dynamic class or module definitions. It is built on top of #6573, so any revieweres please have a look at that one first.This PR changes the expectation of an existing spec, which explicitly stated that this case should not be detected. I don't see why, though. The spec was introduced in d2c0423 as part of a refactor. Neither the commit message nor the associated PR explain the reason for the spec, so I would appreciate some input here.
Also, I'm unsure whether to tag this a "bug fix", "feature", or "change" if this is accepted 馃槂.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).AddedChanged tests.and description in grammatically correct, complete sentences.
bundle exec rake default
. It executes all tests and RuboCop for itself, and generates the documentation.