Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #5956] Make Layout/AccessModifierIndentation work with dynamic modules #6573

Merged
merged 4 commits into from
Dec 23, 2018
Merged

[Fix #5956] Make Layout/AccessModifierIndentation work with dynamic modules #6573

merged 4 commits into from
Dec 23, 2018

Commits on Dec 18, 2018

  1. Move effective_column method to RangeHelp 

    It fits better in there an it also make it possible to reuse the method
in places where `ConfigurableEnforcedStyle` has been separatedly mixed
in.
    @deivid-rodriguez
    deivid-rodriguez committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    515a12a View commit details
    Browse the repository at this point in the history

  2. Extract column_offset_between method 

    And move `effective_colum` under the "private note".
    @deivid-rodriguez
    deivid-rodriguez committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    e5b5306 View commit details
    Browse the repository at this point in the history

  3. [Fix #5956] More robust AccessModifierIndentation 

    Use `end`'s indentation as the base indentation, which is more robust
since it also plays nice with dynamic module or class definitions.
    @deivid-rodriguez
    deivid-rodriguez committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    df515a1 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2018

  1. Merge branch 'master' into access_modifier_indentation_with_dynamic_m… 

    …odules
    @bbatsov
    bbatsov committed Dec 23, 2018
    Configuration menu
    Copy the full SHA
    615ecfc View commit details
    Browse the repository at this point in the history