Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Ctrl-C handling #6461

Merged
merged 2 commits into from
Mar 17, 2019
Merged

Improve Ctrl-C handling #6461

merged 2 commits into from
Mar 17, 2019

Commits on Feb 12, 2019

  1. Reuse cli spec behavior context

    @deivid-rodriguez
    deivid-rodriguez committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    908db03 View commit details
    Browse the repository at this point in the history

  2. Ctrl-C handling by rescuing interrupt 

    By not installing global trap handlers, we prevent any conflicts with any
other installed handlers. This means that, for example, when running cli
or runner specs, one can interrupt rubocop and get the expected Ctrl-C
handling (RSpec's one). It also means that rubocop's Ctrl-C handling is
never leaked outside of rubocop, like it happens when running puma's
test suite.
    @deivid-rodriguez
    deivid-rodriguez committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    2dd246d View commit details
    Browse the repository at this point in the history