Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve description of configuration in README.md. #540

Merged
merged 1 commit into from
Oct 5, 2013

Conversation

jonas054
Copy link
Collaborator

@jonas054 jonas054 commented Oct 4, 2013

This is for #536, but we may want to keep the issue open for discussion a while longer.

Move the sentence about what the configuration file is for, to the first paragraph.

Make the example .rubocop.yml file more realistic by setting parameter values that are different from the default ones.

Clarify the note about AllCops/Excludes.

Make first paragraph under "Including/Excluding files" more clear and simple.

Make "Inheritance" a subchapter, and try to use the word "inherit" rather than "include" when describing inherit_from.

Replace the word folder with directory so we use the same nomenclature throughout the README.

Make "Disabling Cops within Source Code" its own chapter, not under "Configuration", since it has nothing to do with .rubocop.yml.

This is for rubocop#536, but we may want to keep the issue open for discussion a while longer.

Move the sentence about what the configuration file is for, to the first paragraph.

Make the example .rubocop.yml file more realistic by setting parameter values that are different from the default ones.

Clarify the note about AllCops/Excludes.

Make first paragraph under "Including/Excluding files" more clear and simple.

Make "Inheritance" a subchapter, and try to use the word "inherit" rather than "include" when describing inherit_from.

Replace the word folder with directory so we use the same nomenclature throughout the README.

Make "Disabling Cops within Source Code" its own subchapter, not under "Configuration", since it has nothing to do with .rubocop.yml.
bbatsov added a commit that referenced this pull request Oct 5, 2013
Improve description of configuration in README.md.
@bbatsov bbatsov merged commit c9ba4e6 into rubocop:master Oct 5, 2013
@jonas054 jonas054 deleted the describe_excludes branch November 3, 2013 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants