Don't consider <=> for yoda condition 👾 #4603
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe, the `<=>` operator should not be considered for the yoda condition. Maybe `.comparison_method?` shouldn't consider it. The main reason is, that this method in difference to all other comparison methods doesn't return a boolean, but `-1`, `0` or `1`. Thus `0 <=> a` isn't an alternative for `a <=> 0`, because the one returns `-1` while the other returns `1` (unless `a` is `0` of course). I haven't checked, but I'm pretty sure the autocorrect will just exchange the left & right side, which is wrong!
Sounds right to me. What would be the fallout of that change? |
+1 for this. Did a quick check, and the imact should be very close to zero. |
11 tasks
|
Guess #4615 makes this redundant. |
iGEL
added a commit
to iGEL/rubocop
that referenced
this pull request
Aug 24, 2017
I believe, the `<=>` operator should not be considered as a `.comparison_method?`. The main reason is, that this method in difference to all other comparison methods doesn't return a boolean, but `-1`, `0` or `1`. Thus, many assumptions for comparison methods don't apply, for example, there isn't an inverse comparison method (like `<` is the inverse of `>=)`, `* -1` isn't a comparison). This is an alternative to rubocop#4603 by me.
bbatsov
pushed a commit
that referenced
this pull request
Aug 24, 2017
I believe, the `<=>` operator should not be considered as a `.comparison_method?`. The main reason is, that this method in difference to all other comparison methods doesn't return a boolean, but `-1`, `0` or `1`. Thus, many assumptions for comparison methods don't apply, for example, there isn't an inverse comparison method (like `<` is the inverse of `>=)`, `* -1` isn't a comparison). This is an alternative to #4603 by me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe, the
<=>operator should not be considered for the yoda condition. Maybe even.comparison_method?shouldn't consider it.The main reason is, that this method in difference to all other comparison methods doesn't return a boolean, but
-1,0or1. Thus0 <=> aisn't an alternative fora <=> 0, because the one returns-1while the other returns1(unlessais0of course).I haven't checked, but I'm pretty sure the autocorrect will just exchange the left & right side, which is wrong!
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).rake spec) are passing.rake internal_investigation.and description in grammatically correct, complete sentences.
rake generate_cops_documentation(required only when you've added a new cop or changed the configuration/documentation of an existing cop).