Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation and log information for enabling YJIT in LSP #12879

Merged
merged 1 commit into from
May 3, 2024

Conversation

koic
Copy link
Member

@koic koic commented May 2, 2024

This PR adds documentation on enabling YJIT for LSP client to the LSP documentation. It also includes an update to display whether YJIT is enabled or not during LSP startup.

Although it has not been measured, due to its nature as a server, there is a potential for improved execution efficiency with YJIT.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR adds documentation on enabling YJIT for LSP client to the LSP documentation.
It also includes an update to display whether YJIT is enabled or not during LSP startup.

Although it has not been measured, due to its nature as a server, there is a potential
for improved execution efficiency with YJIT.
@koic koic force-pushed the add_doc_and_log_info_for_yjit_in_lsp branch from ffe6208 to 428b7db Compare May 2, 2024 17:41
@bbatsov bbatsov merged commit 67ca096 into rubocop:master May 3, 2024
33 checks passed
@bbatsov
Copy link
Collaborator

bbatsov commented May 3, 2024

Nice addition!

@koic koic deleted the add_doc_and_log_info_for_yjit_in_lsp branch May 3, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants