Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #12865] require 'bundler' if possible and rescue Bundler::GemfileNotFound #12866

Merged
merged 1 commit into from Apr 27, 2024

Conversation

amomchilov
Copy link
Contributor

Closes #12865

This PR improves upon #12826, which tried to require 'bundler' if it's available, we we reverted after #12846.

The issue wasn't the attempt to require Bundler. It was that we were calling Bundler.default_lockfile, which raises Bundler::GemfileNotFound when you're in a folder with no Gemfile.lock.

I can't test this right now, so this is just "blind coding". Can you try it out, @AmShaegar13


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@AmShaegar13
Copy link

Yea, that works. Thanks for taking the time!

@bbatsov bbatsov requested a review from koic April 24, 2024 14:28
… don't crash if we aren't running in a folder with a `Gemfile(.lock)`.
@koic koic merged commit 02aebff into rubocop:master Apr 27, 2024
33 checks passed
@koic
Copy link
Member

koic commented Apr 27, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in v.1.63.3
3 participants