Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false negatives for Lint/UnreachableCode #12857

Conversation

koic
Copy link
Member

@koic koic commented Apr 20, 2024

This PR fixes false negatives for Lint/UnreachableCode when using pattern matching.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes false negatives for `Lint/UnreachableCode`
when using pattern matching.
@bbatsov bbatsov merged commit f1a748b into rubocop:master Apr 20, 2024
33 checks passed
@bbatsov
Copy link
Collaborator

bbatsov commented Apr 20, 2024

Looks good. Thanks!

@koic koic deleted the fix_an_incorrect_autocorrect_for_lint_unreachable_code branch April 20, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants