Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for incompatibilities between Prism 0.25.0 and 0.26.0 #12856

Merged
merged 1 commit into from Apr 19, 2024

Conversation

koic
Copy link
Member

@koic koic commented Apr 19, 2024

This is a workaround for incompatibilities between Prism 0.25.0 and 0.26.0. To upgrade to Prism 0.26+, it is necessary to investigate the following build error and provide feedback to Prism: https://github.com/rubocop/rubocop/actions/runs/8748485587/job/24008584735?pr=12855

I will proceed with these separately.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This is a workaround for incompatibilities between Prism 0.25.0 and 0.26.0.
To upgrade to Prism 0.26+, it is necessary to investigate the following build error and provide feedback to Prism:
https://github.com/rubocop/rubocop/actions/runs/8748485587/job/24008584735?pr=12855

I will proceed with these separately.
@koic koic merged commit dd47fa8 into rubocop:master Apr 19, 2024
33 checks passed
@koic koic deleted the workaround_for_prism_0_26 branch April 19, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant