Set custom program name for the built-in LSP server #12855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR sets custom program name for the built-in LSP server. Before: ```console $ ps aux | grep rubocop user 17414 0.0 0.2 5557716 144376 ?? Ss 4:48PM 0:02.13 /Users/user/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/bin/rubocop --lsp ``` After: ```console $ ps aux | grep 'rubocop' user 17414 0.0 0.2 5557716 144376 ?? Ss 4:48PM 0:02.13 rubocop --lsp /Users/user/src/github.com/rubocop/rubocop ``` When searching for the LSP server process, it is helpful to display the path to the project root instead of the Ruby command path. This approach is already being implemented in server mode: https://github.com/rubocop/rubocop/blob/v1.63.2/lib/rubocop/server/core.rb#L31
koic
force-pushed
the
set_custom_program_name_for_the_builtin_lsp_server
branch
from
9a87b78
to
c819a2d
Compare
|
Nice change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets custom program name for the built-in LSP server.
Before:
After:
When searching for the LSP server process, it is helpful to display the path to the project root instead of the Ruby command path. This approach is already being implemented in server mode: https://github.com/rubocop/rubocop/blob/v1.63.2/lib/rubocop/server/core.rb#L31
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.