[Fix #12146] Fix a false positive for Lint/FloatComparison

[Earlopain]

Allow comparing against 0. See #12387 (comment)

---

Before submitting the PR make sure the following are checked:

• The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
• Wrote good commit messages.
• Commit message starts with [Fix #issue-number] (if the related issue exists).
• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
• Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

[koic]

This cop is categorized under Lint, not Style. 0.zero?, 0.0.zero?, and 0 == 0.0 all return true. Therefore, it doesn't seem like bad code that should be marked as bad in Lint.

It appears that this issue should rather be addressed under Style/NumericPredicate to ensure consistency, I think.

[Earlopain]

0.0 == 0.0 returns true as well but is still flagged by Lint/FloatComparison. That is kind of the point that I made in my initial issue. 0 has special meaning and sometimes it is wanted to check for it. Basically #8432 (comment)

My understanding is that Style/NumericPredicate enforces uniform usage of x == 0 and x.zero? while Lint/FloatComparison makes you aware that you are dealing with floating point numbers and should be careful. This change seems appropriate, at least for how it currently works.

However, if you want to change Lint/FloatComparison to not flag comparision by zero, especially with x.to_f == 0.0 which is currently an offense, I can give that a shot as well.

[koic]

0.0 == 0.0 returns true as well but is still flagged by Lint/FloatComparison.

This looks like a false positive. In any case, registering an offense for zero? by Lint cop seems strict for the users.

However, if you want to change Lint/FloatComparison to not flag comparision by zero, especially with x.to_f == 0.0 which is currently an offense, I can give that a shot as well.

Yeah, that seems reasonable to me. I think zero is special.

[Earlopain]

Sure thing, I'll change it over then. Marking this as draft for the meanwhile.

[Earlopain]

Changed as requested. I'm not entirely sure if I only need to check in on_send but I couldn't think of an example that doesn't work with this

[koic]

Thanks!