[Fix #11984] Add configurable server idle timeout #11985
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll defer to @koic on this one, but I'll mention that it might be nice to be able to set the timeout without with some command-line flag as well. (it would take precedence over the env var) |
It looks good to have a test that uses stubs and mocks. Especially the behavior around the |
koic
reviewed
Jul 6, 2023
| # JSON format does not expected output message when IDE integration with server mode. | ||
| # See: https://github.com/rubocop/rubocop/issues/11164 | ||
| return if use_json_format? | ||
| return nil if use_json_format? |
There was a problem hiding this comment.
I think it was just force of habit, I forgot the two are equivalent. I'll revert it since the older line is more concise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for a new environment variable when running rubocop in server mode,
RUBOCOP_SERVER_IDLE_TIMEOUT.When the variable is set, it's interpreted as a number of seconds, and the server will automatically exit if that many seconds pass without receiving any connections.
I'm hesitant to add tests since they'll likely be timing-sensitive (read: inconsistent) and/or might slow down the suite with
sleeps.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.