Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Workaround for Style/RedundantBegin when using JRuby 9.2" #11922

Commits on Jun 3, 2023

  1. Revert "Workaround for Style/RedundantBegin when using JRuby 9.2"

    ## Summary
    
    Revert rubocop@1533ece
    
    Current RuboCop (1.52) requires Ruby 2.7+ and JRuby 9.4+.
    So JRuby 9.2 has been dropped from runtime version.
    
    ## Additional Information
    
    jruby/jruby#6642 has been resolved in JRuby 9.4:
    
    ```ruby
    # example.rb
    require 'ripper'
    
    class RipperParser < Ripper
      def on_parse_error(message)
        raise message
      end
    end
    
    RipperParser.new(<<~RUBY).parse
      foo do
        bar do
      end
    rescue NameError
      converted << nil
    end
    RUBY
    ```
    
    ```console
    $ ruby -v
    jruby 9.4.2.0 (3.1.0) 2023-03-08 90d2913fda Java HotSpot(TM) 64-Bit Server VM 25.271-b09 on 1.8.0_271-b09 +jit [x86_64-darwin]
    $ ruby example.rb # No errors
    ```
    koic committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    166c8c8 View commit details
    Browse the repository at this point in the history