Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #11554] Fix an error for Style/RedundantCondition #11555

Merged

Conversation

koic
Copy link
Member

@koic koic commented Feb 8, 2023

Fixes #11554.

This PR fixes an error for Style/RedundantCondition when the branches contains empty hash literal argument.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Fixes rubocop#11554.

This PR fixes an error for `Style/RedundantCondition`
when the branches contains empty hash literal argument.
@bbatsov bbatsov merged commit dca9221 into rubocop:master Feb 8, 2023
@bbatsov
Copy link
Collaborator

bbatsov commented Feb 8, 2023

Thanks!

@koic koic deleted the fix_an_error_for_style_redundant_condition branch February 8, 2023 17:36
@gnomonunes
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rubocop 1.45.0 - Style/RedundantCondition: undefined method `kwsplat_type?' for nil:NilClass
3 participants