Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore a pending test for processing a regex with regopt #11553

Merged

Conversation

koic
Copy link
Member

@koic koic commented Feb 8, 2023

This PR reverts a pending test of #10432 because jruby/jruby#7113 has been resolved in JRuby 9.3.9.0.

JRuby 9.3.3.0

RegexpError error will occur:

% rbenv local jruby-9.3.3.0
% ruby -e "Regexp.new('\x82', Regexp::NOENCODING)"
RegexpError: invalid multibyte escape: /\x82/
  initialize at org/jruby/RubyRegexp.java:956
         new at org/jruby/RubyClass.java:893
      <main> at -e:1

JRuby 9.3.9.0 and JRuby 9.4.1.0

No errors:

% rbenv local jruby-9.3.9.0
% ruby -e "Regexp.new('\x82', Regexp::NOENCODING)"

% rbenv local jruby-9.4.1.0
% ruby -e "Regexp.new('\x82', Regexp::NOENCODING)"

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR reverts a pending test of rubocop#10432 because jruby/jruby#7113
has been resolved in JRuby 9.3.9.0.

## JRuby 9.3.3.0

`RegexpError` error will occur:

```console
% rbenv local jruby-9.3.3.0
% ruby -e "Regexp.new('\x82', Regexp::NOENCODING)"
RegexpError: invalid multibyte escape: /\x82/
  initialize at org/jruby/RubyRegexp.java:956
         new at org/jruby/RubyClass.java:893
      <main> at -e:1
```

## JRuby 9.3.9.0 and JRuby 9.4.1.0

No errors:

```console
% rbenv local jruby-9.3.9.0
% ruby -e "Regexp.new('\x82', Regexp::NOENCODING)"

% rbenv local jruby-9.4.1.0
% ruby -e "Regexp.new('\x82', Regexp::NOENCODING)"
```
@koic koic force-pushed the restore_test_for_processing_a_regex_with_regopt branch from 01a78c1 to 519adef Compare February 8, 2023 15:31
@koic koic changed the title Restore test for processing a regex with regopt Restore a pending test for processing a regex with regopt Feb 8, 2023
@bbatsov bbatsov merged commit cdfc397 into rubocop:master Feb 8, 2023
@koic koic deleted the restore_test_for_processing_a_regex_with_regopt branch February 8, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants