Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive for Lint/Debugger when methods containing different method chains #11552

Merged
merged 1 commit into from
Feb 8, 2023

Commits on Feb 8, 2023

  1. Fix a false positive for Lint/Debugger when methods containing diff…

    …erent method chains
    
    This PR is fix a false positive for `Lint/Debugger` when methods containing different method chains.
    
    ## Motivation
    I don't think that methods such as `p.do_something` for example should be an offense of this cop.
    I think it would be better to make it a violation only if it is an exact match, including the method chain, but what do you think?
    
    ## This PR will result in the following
    
    ```ruby
    # bad
    p 'foo'
    foo(p 'foo')
    p(p 'foo')
    
    # good
    p.do_something
    Foo.p
    ```
    ydah committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    23cc42b View commit details
    Browse the repository at this point in the history