Make Lint/UselessAccessModifier aware of Ruby 3.2's Data.define
#11546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
make_useless_access_modifier_aware_of_data_define
branch
from
7a9cf23
to
35720e6
Compare
Ruby 3.2 introduced immutable `Data.define`. Since this is similar to `Struct.new`. This `Lint/UselessAccessModifier` will handle `Struct.new` and `Data.define` in the same way.
koic
force-pushed
the
make_useless_access_modifier_aware_of_data_define
branch
from
35720e6
to
a13587b
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 3.2 introduced immutable
Data.define. Since this is similar toStruct.new. ThisLint/UselessAccessModifierwill handleStruct.newandData.definein the same way.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.